Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "Testing with Rust / Writing Tests" example #5539

Merged
merged 4 commits into from
Sep 9, 2024
Merged

Fix "Testing with Rust / Writing Tests" example #5539

merged 4 commits into from
Sep 9, 2024

Conversation

smoelius
Copy link
Contributor

@smoelius smoelius commented Feb 2, 2024

Description

The harnes.rs code that currently appears in the book seems to be out of date (it doesn't compile).

The proposed code was copied from the sway-test-rs template.

(The Sway tutorial is very good, BTW.)

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@smoelius
Copy link
Contributor Author

smoelius commented Feb 6, 2024 •
edited
Loading

I'm not sure if the checklist items apply. I think this PR is good to go.

@sarahschwartz
Copy link
Contributor

A more permanent solution for this would be to import the code snippet from a tested example file. You can see how that is done here: https://github.com/FuelLabs/sway/blob/master/docs/book/src/basics/converting_types.md

@sdankel sdankel requested review from a team as code owners September 9, 2024 20:50
@JoshuaBatty JoshuaBatty merged commit c55ad21 into FuelLabs:master Sep 9, 2024
42 checks passed
@smoelius smoelius deleted the patch-1 branch September 10, 2024 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IGI-111 IGI-111 IGI-111 left review comments

@JoshuaBatty JoshuaBatty JoshuaBatty approved these changes

@sdankel sdankel sdankel approved these changes

@sarahschwartz sarahschwartz Awaiting requested review from sarahschwartz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@smoelius @sarahschwartz @JoshuaBatty @IGI-111 @sdankel